fix(core): honor config requestOptions in ContinueServerClient#12966
Open
wuisabel-gif wants to merge 1 commit into
Open
fix(core): honor config requestOptions in ContinueServerClient#12966wuisabel-gif wants to merge 1 commit into
wuisabel-gif wants to merge 1 commit into
Conversation
dosubot
Bot
added
the
size:L
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA. |
Config-sync and index-cache requests used global fetch(), ignoring config.yaml requestOptions (proxy, verifySsl, caBundlePath). Route them through fetchwithRequestOptions like the LLM path already does. Fixes continuedev#12956
wuisabel-gif
force-pushed
the
fix/continue-server-client-request-options
branch
from
7703b56 to
259a6e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Config-sync and index-cache requests in
ContinueServerClientused the globalfetch(), soconfig.yamlrequestOptions(proxy,verifySsl,caBundlePath) were ignored on those paths. Behind an HTTPS-intercepting corporate proxy with a custom CA, this surfaces as a startup "Connection error" in core.log even though LLM requests work fine (they already go throughfetchwithRequestOptions).This routes the client's requests through
fetchwithRequestOptionsand passesconfig.requestOptionsin fromCodebaseIndexer, so the same proxy/TLS settings apply to config sync and index caching.Fixes #12956
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
N/A — network-path change with no UI. Any request made by
ContinueServerClientpreviously bypassedconfig.yamlrequestOptions; after this change it uses them.Tests
Added
core/continueServer/stubs/client.vitest.ts— verifiesgetConfigandgetFromIndexCacheforward the constructor'srequestOptionstofetchwithRequestOptions.